Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 9, 2025

PR-Codex overview

This PR introduces a new helper function for sending usageV2 events, enhancing authentication options for internal services and public clients. It updates the documentation and refines the logic for determining the endpoint and headers based on the provided authentication method.

Detailed summary

  • Added UsageV2Options type to define authentication options.
  • Updated documentation for sendUsageV2Events to clarify authentication requirements.
  • Refined logic for determining the endpoint and headers based on serviceKey, thirdwebSecretKey, or thirdwebClientId.
  • Improved error message for unexpected responses.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner February 9, 2025 09:25
@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2025

🦋 Changeset detected

Latest commit: b3c5112

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:26am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:26am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:26am
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:26am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:26am

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@arcoraven arcoraven merged commit 6f2f92d into main Feb 9, 2025
30 of 31 checks passed
@arcoraven arcoraven deleted the ph/publishUsageIngestEndpoint branch February 9, 2025 09:26
@codecov
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (b73fa4b) to head (b3c5112).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6212      +/-   ##
==========================================
- Coverage   56.77%   56.72%   -0.05%     
==========================================
  Files        1161     1161              
  Lines       64261    64289      +28     
  Branches     5196     5196              
==========================================
- Hits        36483    36468      -15     
- Misses      27050    27095      +45     
+ Partials      728      726       -2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b73fa4b
packages 54.89% <ø> (-0.06%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

@joaquim-verges joaquim-verges mentioned this pull request Feb 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.28 KB (0%) 926 ms (0%) 3.9 s (-6.67% 🔽) 4.9 s
thirdweb (cjs) 122.06 KB (0%) 2.5 s (0%) 7 s (-6.65% 🔽) 9.5 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 389 ms (-13.27% 🔽) 501 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 128 ms (-29.99% 🔽) 138 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 858 ms (-36.39% 🔽) 1.3 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants